[Merged by Bors] - sql: add Database.WithConnection #6445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a possibility to take a connection from the pool to use it via the Executor interface, and return it later when it's no longer needed. This avoids connection pool overhead in cases when a lot of quries need to be made, but the use of read transactions is not needed. Using read transactions instead of simple connections has the side effect of blocking WAL checkpoints.
ivan4th
requested review from
dshulyak,
fasmat,
poszu,
acud and
jellonek
as code owners
fasmat
requested changes
Nov 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6445 +/- ##
=========================================
- Coverage 79.9% 79.9% -0.1%
=========================================
Files 352 352
Lines 46096 46126 +30
=========================================
+ Hits 36865 36870 +5
- Misses 7142 7161 +19
- Partials 2089 2095 +6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ivan4th
changed the title
fasmat
approved these changes
Nov 13, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
------- ## Motivation In some situations (most notably, syncv2) a lot of database queries need to be made with no need for a read or write transaction. Database connection pool adds noticeable delays to the queries. Using read transactions instead of simple connections has the side effect of blocking WAL checkpoints.
|
Build failed: |
|
systest failure: This looks like stuck network or smth like that. |
|
I'm not exactly sure what went wrong, but all smeshers were deployed quite late: https://grafana.spacemesh.dev/goto/wJ_klsGHg?orgId=1
|
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
## Motivation In some situations (most notably, syncv2) a lot of database queries need to be made with no need for a read or write transaction. Database connection pool adds noticeable delays to the queries. Using read transactions instead of simple connections has the side effect of blocking WAL checkpoints.
|
Build failed:
|
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Nov 17, 2024
## Motivation In some situations (most notably, syncv2) a lot of database queries need to be made with no need for a read or write transaction. Database connection pool adds noticeable delays to the queries. Using read transactions instead of simple connections has the side effect of blocking WAL checkpoints.
|
Pull request successfully merged into develop. Build succeeded:
|
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In some situations (most notably, syncv2) a lot of database queries
need to be made with no need for a read or write transaction.
Database connection pool adds noticeable delays to the queries.
Using read transactions instead of simple connections has the side
effect of blocking WAL checkpoints.
Description
This adds a possibility to take a connection from the pool to use it
via the Executor interface, and return it later when it's no longer
needed. This avoids connection pool overhead in cases when a lot of
quries need to be made, but the use of read transactions is not
needed.
Additionally, this PR removes unused
Rollbackmethod from migrations.The failed migrations are reverted either by rolling back the transactions
or dropping the temporary database used when vacuuming is needed.
UPD:
Rollbackmethod can be useful after all, so reverted this part of the PR.